Changeset 6919 for source/ariba/overlay/BaseOverlay.cpp

Timestamp:

Nov 13, 2009, 1:41:34 PM (15 years ago)

Author:

mies

Message:

Fixed tons of warnings when using CXXFLAGS="-Wall"!

File:

• source/ariba/overlay/BaseOverlay.cpp (modified) (6 diffs)

source/ariba/overlay/BaseOverlay.cpp

@@ -148 +148 @@
         static bool equals( const Data& lhs, const Data& rhs ) {
                 if (rhs.getLength()!=lhs.getLength()) return false;
-                for (int i=0; i<lhs.getLength()/8; i++)
+                for (size_t i=0; i<lhs.getLength()/8; i++)
                         if (lhs.getBuffer()[i] != rhs.getBuffer()[i]) return false;
                 return true;
@@ -604 +604 @@
         message->setDestinationNode(remote);
         message->setService(service);
-        send( message, remote );
+        return send( message, remote );
 }
 
@@ -747 +747 @@
 
 BaseOverlay::BaseOverlay() :
-                        bc(NULL), overlayInterface(NULL), nodeId(NodeID::UNSPECIFIED),
-                        spovnetId(SpoVNetID::UNSPECIFIED), state(BaseOverlayStateInvalid),
-                        sideport(&SideportListener::DEFAULT), started(false), counter(0) {
+                        started(false),state(BaseOverlayStateInvalid),
+                        bc(NULL),
+                        nodeId(NodeID::UNSPECIFIED), spovnetId(SpoVNetID::UNSPECIFIED),
+                        sideport(&SideportListener::DEFAULT), overlayInterface(NULL),
+                        counter(0) {
         dht = new DHT();
         localDHT = new DHT();
@@ -1158 +1160 @@
         sideport = _sideport;
         _sideport->configure( this );
+        return true;
 }
 
 bool BaseOverlay::unregisterSidePort(SideportListener* _sideport) {
         sideport = &SideportListener::DEFAULT;
+        return true;
 }
 
@@ -1789 +1793 @@
         // erase the original descriptor
         eraseDescriptor(ld->overlayId);
+        return true;
 }
 
@@ -2182 +2187 @@
 void BaseOverlay::dhtPut( const Data& key, const Data& value, int ttl, bool replace, bool no_local_refresh ) {
 
-        logging_info("DHT: putting key=" <<  key
-                        << " value=" << value
-                        << " ttl=" << ttl
-                        << " replace=" << replace
+        logging_info("DHT: putting key=" << key << " value=" << value
+                << " ttl=" << ttl << " replace=" << replace
         );